Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intervention error #27639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hanif-tiznobake
Copy link

bug: [Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

bug: [Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.
@microsoft-github-policy-service

@Haniov please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@hanif-tiznobake
Copy link
Author

@microsoft-github-policy-service agree

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fe787c9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 19, 2023

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-Dialog 199.141 kB 199.157 kB ExceedsBaseline     16 bytes
office-ui-fabric-react fluentui-react-Panel 188.818 kB 188.834 kB ExceedsBaseline     16 bytes
office-ui-fabric-react fluentui-react-Utilities 71.283 kB 71.299 kB ExceedsBaseline     16 bytes
office-ui-fabric-react fluentui-react-Dropdown 221.031 kB 221.047 kB ExceedsBaseline     16 bytes
office-ui-fabric-react fluentui-react-Modal 88.663 kB 88.679 kB ExceedsBaseline     16 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 9815f72fe8f53e4e505f68c74a256aa648fde84d (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 9815f72fe8f53e4e505f68c74a256aa648fde84d

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 918 957 5000
Breadcrumb mount 2498 2562 1000
Checkbox mount 2507 2493 5000
CheckboxBase mount 2172 2268 5000
ChoiceGroup mount 4232 4367 5000
ComboBox mount 996 1055 1000
CommandBar mount 9214 9256 1000
ContextualMenu mount 17032 16930 1000
DefaultButton mount 1121 1135 5000
DetailsRow mount 3316 3297 5000
DetailsRowFast mount 3377 3362 5000
DetailsRowNoStyles mount 3085 3074 5000
Dialog mount 4034 4044 1000
DocumentCardTitle mount 373 364 1000
Dropdown mount 2920 2928 5000
FocusTrapZone mount 1712 1749 5000
FocusZone mount 1660 1659 5000
GroupedList mount 56683 65539 2
GroupedList virtual-rerender 27866 27555 2
GroupedList virtual-rerender-with-unmount 83916 84508 2
GroupedListV2 mount 366 367 2
GroupedListV2 virtual-rerender 344 351 2
GroupedListV2 virtual-rerender-with-unmount 404 374 2
IconButton mount 1660 1642 5000
Label mount 527 524 5000
Layer mount 4152 4075 5000
Link mount 608 605 5000
MenuButton mount 1390 1412 5000
MessageBar mount 31432 31646 5000
Nav mount 2924 2958 1000
OverflowSet mount 1177 1165 5000
Panel mount 2616 2628 1000
Persona mount 1069 1112 1000
Pivot mount 1346 1346 1000
PrimaryButton mount 1267 1268 5000
Rating mount 6568 6690 5000
SearchBox mount 1316 1301 5000
Shimmer mount 2661 2688 5000
Slider mount 1943 1978 5000
SpinButton mount 4297 4456 5000
Spinner mount 586 593 5000
SplitButton mount 2775 2785 5000
Stack mount 611 614 5000
StackWithIntrinsicChildren mount 1295 1300 5000
StackWithTextChildren mount 3682 3632 5000
SwatchColorPicker mount 9186 9361 5000
TagPicker mount 2279 2228 5000
Text mount 566 557 5000
TextField mount 1361 1354 5000
ThemeProvider mount 1306 1289 5000
ThemeProvider virtual-rerender 876 885 5000
ThemeProvider virtual-rerender-with-unmount 2026 1972 5000
Toggle mount 930 901 5000
buttonNative mount 342 320 5000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants